search

fuel / docs

Fuel PHP Framework - Fuel v1.x documentation
http://fuelphp.com/docs
Other
168 stars 234 forks source link

Added Arr::keyval_to_assoc docs #622

Closed sagikazarmark closed 10 years ago

sagikazarmark commented 10 years ago

I don't get this in the title:

keyval_to_assoc($array = null, $key_field = null, $val_field = null)

Why are those values null, when the arguments are required?

(Copy and paste from assoc_to_keyval)

WanWizard commented 10 years ago

are they null in the code? If not, then the docs are incorrect (and if they are, the code is incorrect too, since you are right, they are required).

sagikazarmark commented 10 years ago

No, in the code they are not null, so the docs are incorrect.

Would you like me to correct it?

WanWizard commented 10 years ago

Yes please. Then I can merge this.

sagikazarmark commented 10 years ago

Ok. But keep in mind, that this PR depends on the PR sent for core.

WanWizard commented 10 years ago

I'll merge that one too. ;)

sagikazarmark commented 10 years ago

@WanWizard docs corrected. I also found another one, so I corrected that too.