search

fuel / email

Fuel PHP Framework - Fuel v1.x Email library
60 stars 38 forks source link

Add return type to docblock for \Email\Email::forge #21

Closed richard-myers closed 12 years ago

richard-myers commented 12 years ago

Could you please add the return type to the docblock for the forge function so we can get type hinting on the returned object.

/*
 * ...
 * @return  Email_Driver
 */
public static function forge($setup = null, array $config = array())
frankdejonge commented 12 years ago

Richard, I appreciate what you doing here, but you can easily send a pull request for this. Just saying "Fix this" does get a little annoying after a while. This can even be done in github in your fork, you don't even need to setup git on your local machine. There are also a lot of tutorials on how to send pull requests, fork, commit and all other stuff.