search

fuel / email

Fuel PHP Framework - Fuel v1.x Email library
60 stars 38 forks source link

FuelPHP sets return-path from_email instead of the email of return-path #67

Closed Khanashima closed 8 years ago

Khanashima commented 8 years ago

Fixed return path settings

FuelPHP sets return-path from_email instead of the email of return-path

xKerman commented 8 years ago

When I tested with CentOS6' postfix SMTP server and FuelPHP's SMTP driver (1.9/develop), Return-Path header doesn't set for return_path config. (from.email was set)

I used https://gist.github.com/xKerman/4b1c1b59cd81009f61580ef72d770d59 for the test.

After I applied this pull request, Return-Path header set for return_path config. Why has not this pull request merged? @WanWizard

WanWizard commented 8 years ago

Urhm.... Not sure why I closed this without comments. Problem is it is a PR on fuel:1.8/develop, so it can't be merged.

xKerman commented 8 years ago

I see, so if @Khanashima (or somebody else including me) makes this PR on 1.9/develop, it seems that everything goes well.

WanWizard commented 8 years ago

Yes, it seems to be correct to use the return path as the envelope from when set.