search

fuel / email

Fuel PHP Framework - Fuel v1.x Email library
60 stars 38 forks source link

Don't attach https urls #9

Closed felixkoch closed 12 years ago

felixkoch commented 12 years ago

In driver.php, Line 187: if (($beginning = substr($image_url, 0, 7)) !== 'http://' and $beginning !== 'htts://' and substr($image_url, 0, 4) !== 'cid:') Should be: if (substr($image_url, 0, 7) !== 'http://' and substr($image_url, 0, 8) !== 'https://' and substr($image_url, 0, 4) !== 'cid:')

felixkoch commented 12 years ago

That is still wrong: 'https://' has 8 chars not 7. Use the code I suggested.

frankdejonge commented 12 years ago

This has already been fixed in a later commit. If you want to us to use your code. Send a pull request, don't say "Use this".

felixkoch commented 12 years ago

Sorry and Thank you.