search

fuel / helpers

FuelPHP Framework - Generic helpers library
MIT License
17 stars 7 forks source link

Fix Arr, CookieJar and Date classes so that tests pass #9

Closed falexandrou closed 9 years ago

falexandrou commented 9 years ago

Signed-off-by: Fotis Alexandrou falexandrou@gmail.com

falexandrou commented 9 years ago

Hi @stevewest

Please review my PR

Thanks

emlynwest commented 9 years ago

No need to highlight me, I get notifications for everything

WanWizard commented 9 years ago

For now, the only option is to remove the implements DateTimeInterface, since the fine people at PHP have borked that one. The seperate DateTimeInterface class can go alltogether, it was used to emulate it in PHP 5.4, but since v2 is now 5.5+, that is no longer relevant.

WanWizard commented 9 years ago

And @sagikazarmark, I wasn't drunk. ;-)

At the time it was designed, it was no problem using the interface in PHP 5.5. I haven't been able to test it again in 5.5, but it looks like it's broken in 5.6...

sagikazarmark commented 9 years ago

Realised that, my apologies. :)