fuel / oil

Fuel PHP Framework - Fuel v1.x Oil command-line package
http://fuelphp.com/docs/packages/oil/intro.html
106 stars 67 forks source link

Add module support to oil #222

Closed philipptempel closed 10 years ago

philipptempel commented 10 years ago

Patch adds module support for (as of now) the following oil commands

Furthermore, a new oil generate command oil g module is added to allow for creating modules with an additional option --folders= to automatically create specified folders. Example usage

oil g module portfolio --folders=classes/controller,classes/model,config,lang

oil g module also checks whether the app has configured multiple module paths as in config module_paths and gives a nice select prompt if there's more than one module path defined

Would love to see the PR accepted and merged into 1.8, but maybe there's no more need for it before Fuel v2 will be released.

WanWizard commented 10 years ago

Can you go through it and check for violations of the coding standard?

For example the use of spaces in brackets:

if ( $module = \Cli::option('module') )
if ( $module )
foreach ( $module_paths as $key => $path )

should be

if ($module = \Cli::option('module'))
if ($module)
foreach ($module_paths as $key => $path)

Also, can you add this to the oil docs?

philipptempel commented 10 years ago

Sure, I will be updating my PR within the next days to include both, checks for violation of the coding standard as well as a PR to fuel/docs to include the changes introduced by my PR.

Just wanted to check whether it's reasonable at all to make a PR or if there will be no more Fuel v1 releases now that v2 is on the horizon ;)

WanWizard commented 10 years ago

Any update? Also, no docs yet?

philipptempel commented 10 years ago

Working on it.Trying to make at least the coding standards match tonight. Docs shouldn't be that much then, but can't promise that it's going to happen tonight, but will by the end of the week :)