Closed philipptempel closed 10 years ago
Can you go through it and check for violations of the coding standard?
For example the use of spaces in brackets:
if ( $module = \Cli::option('module') )
if ( $module )
foreach ( $module_paths as $key => $path )
should be
if ($module = \Cli::option('module'))
if ($module)
foreach ($module_paths as $key => $path)
Also, can you add this to the oil docs?
Sure, I will be updating my PR within the next days to include both, checks for violation of the coding standard as well as a PR to fuel/docs to include the changes introduced by my PR.
Just wanted to check whether it's reasonable at all to make a PR or if there will be no more Fuel v1 releases now that v2 is on the horizon ;)
Any update? Also, no docs yet?
Working on it.Trying to make at least the coding standards match tonight. Docs shouldn't be that much then, but can't promise that it's going to happen tonight, but will by the end of the week :)
Patch adds module support for (as of now) the following oil commands
oil g controller
oil g model
oil g migration
oil g task
oil g views
Furthermore, a new oil generate command
oil g module
is added to allow for creating modules with an additional option--folders=
to automatically create specified folders. Example usageoil g module
also checks whether the app has configured multiple module paths as in configmodule_paths
and gives a nice select prompt if there's more than one module path definedWould love to see the PR accepted and merged into 1.8, but maybe there's no more need for it before Fuel v2 will be released.