Workaround for limitation of PHP 5.x COW design

fuel / orm

Fuel PHP Framework - Fuel v1.x ORM

http://fuelphp.com/docs/packages/orm/intro.html

151 stars 95 forks source link

Workaround for limitation of PHP 5.x COW design #364

Closed pmccarren closed 9 years ago

pmccarren commented 9 years ago

When pulling a large number of records the ORM would get exponentially slower. The issue was tracked down to a PHP limitation. We filed https://bugs.php.net/bug.php?id=68624

PHP developer suggests issue will be resolved in PHP 7

WanWizard commented 9 years ago

@stevewest any objections?

emlynwest commented 9 years ago

I don't have an issue with this, it's certainly not the worst workaround that I have seen and if it can make the ORM perform better then I'm happy for it to be merged.

WanWizard commented 9 years ago

Had to revert it, this change made results global, which completely f'd up the results if hydrate() had to iterate (which is does when eager loading relations).