search

fuel / parser

Fuel PHP Framework - v1.x template parser package adapters
http://fuelphp.com
64 stars 45 forks source link

Parser\View::factory() declaration incompatible with Fuel\Core\View::factory() #25

Closed paulboco closed 13 years ago

paulboco commented 13 years ago

I keep getting the following error in the logs when using Fuel 1.0.1.

Error - 2011-08-26 12:39:13 --> 2048 - Declaration of Parser\View::factory() should be compatible with that of Fuel\Core\View::factory() in /home/pbc/sites/rpm/fuel/packages/parser/classes/view.php on line 17

This commit seems to fix the problem.

jschreuder commented 13 years ago

This is because the Parser package is compatible with v1.1, which it'll be included in soon. Thus this won't change as it'll give the same problem for anyone on the 1.1/develop branch of core.

As this package is still in development and has no "master" for 1.0 this won't go in, after 1.1 the Parser package will be part of the normal release structure that also keeps support for older versions.