search

fuel9 / DisplayMonkey

Display Monkey digital signage solution
Other
127 stars 51 forks source link

Transl de #37

Closed halloamt closed 6 years ago

halloamt commented 6 years ago

Hi,

I started a German translation and added a cookie for display registration. Could you have a look at the two patches ?

Thanks and greetings brom the black forest

HA

psined1 commented 6 years ago

Hi, thank you for contributing to the project.

To be able to support legacy DM implementations, there are a couple things in your code that we would like changed before merging this PR. Since the IP-address method is already used around the community, we want the cookie-based method depend on a system parameter. Another minor thing, the DM distribution is shipped with generic SQL account for database strings in web.config, so we'll reverse it back to where it was.

I'm going to fetch your PR into a new DM branch called "cookies", then add new system parameter and relevant changes. You can then fork and test.