search

fuelen / ecto_dev_logger

An alternative logger for Ecto queries
Apache License 2.0
151 stars 16 forks source link

Add Support For Tds Adapter #3

Closed garretttaco closed 2 years ago

garretttaco commented 2 years ago

Hey! Great library. We use SQL Server at my job and so I wanted to add support for the Ecto.Adapters.Tds params which use the @ scalar variable declaration.

I figured adding tests for this may be tricky since you would most likely need a docker instance setup with the MSSQL Docker image (mcr.microsoft.com/mssql/server:2019-latest), and you may not want that in your tests without full docker support on the PostgreSQL DB as well. Let me know your thoughts there.

Garrett

fuelen commented 2 years ago

Hi Garrett!

Thank you for the contribution. I'm happy to merge this, but 1 small adjustment is needed. Could you please move repo_adapter outside the loop?

garretttaco commented 2 years ago

Good catch! I moved it out of the loop.

fuelen commented 2 years ago

Thank you!