Ecto.Adapters.MySQL uses different param placeholder

fuelen / ecto_dev_logger

An alternative logger for Ecto queries

Apache License 2.0

147 stars 14 forks source link

Ecto.Adapters.MySQL uses different param placeholder #8

Closed sh41 closed 2 years ago

sh41 commented 2 years ago

Just a note for anyone who like me was trying to figure out why this wasn't working on a MySQL project. MySQL's placeholder is ? rather than $1 etc. As a result the DevLogger doesn't replace the right things. I may have a look at a PR for this is I have time, but for the moment hopefully this saves others time when trying to figure out what's happening.

Great project by the way! I'm looking forward to using it on a Postgres codebase. :D

fuelen commented 2 years ago

Hey @sh41

I've pushed a commit with support for Ecto.Adapters.MyXQL adapter to main. Could you test it? :)

sh41 commented 2 years ago

Thanks @fuelen! Looks great!

It's highlighted something a little odd with some of the strings we're using, but I'll raise another issue for that as it's unrelated to the adapter used.

fuelen commented 2 years ago

Released in v0.3.0

sh41 commented 2 years ago

❤️ 💚 💛 🧡