search

fuelphp / upload

FuelPHP Framework - File upload library
MIT License
26 stars 16 forks source link

Somethign wrong when upgrading from 2.0.2 to 2.0.3 #12

Closed huglester closed 9 years ago

huglester commented 9 years ago

Hello,

in 2.0.2, File $container->filename - had filename of the uploaded file; now it is null (in 2.0.3)

What is the correct way to get uploaded filename?

Thanks

WanWizard commented 9 years ago

In what exact situation? Succesful upload, or one with errors?

WanWizard commented 9 years ago

Did a quick check, but nothing significant seems to have changed in that area.

The filename is set at https://github.com/fuelphp/upload/blob/master/src/File.php#L419, and it gets there as long as the file was uploaded without errors and the path the file has to be written to exists and is accessable.

What has changed is that every save step is now only executed if the previous one went ok, as soon as an error occurs the save process stops.

it-can commented 9 years ago

I may have the same issues: https://github.com/fuelphp/upload/issues/14

WanWizard commented 9 years ago

Think I found it. Is someone able to test this fix, I'm not in a position to atm.

huglester commented 9 years ago

hello,

@WanWizard I can confirm, it works now. So: 2.0.2 - works 2.0.3 - does not dev-master - works

WanWizard commented 9 years ago

Ok, thanks for the quick confirmation, I'll tag 2.0.4.