search

fugue / credstash

A little utility for managing credentials in the cloud
Apache License 2.0
2.06k stars 214 forks source link

Force cryptography<2.1 #174

Closed afallou closed 7 years ago

afallou commented 7 years ago

In version 2.1 of cryptography, support for RIPEMD160 hashes got removed (see cryptography master vs 2.0.x ), but Credstash still points to those. I chose to modify setup.py rather than remove that hash family from credstash, as that would probably be disruptive for other users of credstash.

andrewkrug commented 7 years ago

Related to #175

andrewkrug commented 7 years ago

Fixes #175

williamsbdev commented 7 years ago

Well done @afallou! LGTM

sjwoodr commented 7 years ago

This change fixed it for me as well. Thank you!

jomunoz commented 7 years ago

I think the proper solution would be: https://github.com/fugue/credstash/pull/176

wayne-luminal commented 7 years ago

Thanks for the quick PR @afallou! I'm merging this to get credstash usable again and will take a look at #176.