RIPEMD160 removed in cryptography 2.1

fugue / credstash

A little utility for managing credentials in the cloud

Apache License 2.0

2.06k stars 214 forks source link

RIPEMD160 removed in cryptography 2.1 #201

Closed jwineinger closed 6 years ago

jwineinger commented 6 years ago

Whirlpool and RIPEMD160 were removed in cryptography 2.1 (https://cryptography.io/en/latest/changelog/#v2-1) which causes credstash to break due to:

https://github.com/fugue/credstash/blob/master/credstash.py#L55-L56

  File "/usr/local/lib/python2.7/site-packages/credstash.py", line 54, in <module>
    'RIPEMD': hashes.RIPEMD160,
AttributeError: 'module' object has no attribute 'RIPEMD160'

marcfielding1 commented 6 years ago

Yeah I'm hitting this in a circleCI build(Ubuntu), oddly enough when I install on my Mac it works fine, it may be I have some different versions of the libraries as I've had python and lots of python packages installed for a quite a while.

a12k commented 6 years ago

@marcfielding1 Same here, but as soon as I updated my cryptography it started breaking. I just had an old version. There's a pull request up to remove support for RIPEMD and WHIRLPOOL, fyi.

glyph commented 6 years ago

The PR in question is #178.

alex-luminal commented 6 years ago

merged