search

fugue / credstash

A little utility for managing credentials in the cloud
Apache License 2.0
2.06k stars 214 forks source link

Fix SyntaxWarnings showing up in python 3.8 #260

Closed aerostitch closed 4 years ago

aerostitch commented 5 years ago

Hi guys,

Thanks for this software. We recently upgraded our python to 3.8 to test the compatibility and when running credstash we get the following warnings:

/usr/local/bin/credstash.py:111: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  self.value = "KMS ERROR: " + value if value is not "" else "KMS ERROR"
/usr/local/bin/credstash.py:120: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  self.value = "INTEGRITY ERROR: " + value if value is not "" else \

This PR fixes those.

These warnings are problematic when you use the result of the credstash output in a variable using $(). Thanks