fugue / credstash

A little utility for managing credentials in the cloud
Apache License 2.0
2.06k stars 215 forks source link

fatal function may impede the downstream APIs functionality #303

Open Raviteja-Ainampudi opened 3 years ago

Raviteja-Ainampudi commented 3 years ago

https://github.com/fugue/credstash/blob/df24f9189e843e0cdc700c015ee4f37fbd35dc40/credstash.py#L165

I suggest removing the os.exit(1) because, it might hinder the functionality of any downstream API. I'm not sure, if that line of code will actually help the functionality of Credstash.

My experience: I was trying to use Credstash in AWS lambda, and need to extract passwords for a list of keys. But, this sys.exit(1) causes the whole lambda to exit. Ofcourse, I can change the source code. But I want to suggest this such that the scope of Credstash can be improved among the developer community. If anybody is having Credstash among their Upstream APIs.