Closed fuhrmanator closed 5 years ago
It appears this issue was cleared up on PlantUML.com's server. Closing this.
Does this mean your warning in the initial project readme can now be removed? i was a bit put off trying it if I had to download a server of my own... so its great news if its not an issue
Yes, I will remove the warning.
On Mon, Aug 12, 2019, 23:58 Tim Mackinnon notifications@github.com wrote:
Does this mean your warning in the initial project readme can now be removed? i was a bit put off trying it if I had to download a server of my own... so its great news if its not an issue
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fuhrmanator/PlantUMLPharoGizmo/issues/2?email_source=notifications&email_token=AB2BCDC2FZAVZEANM5PNC5TQEHMJ7A5CNFSM4HWOOSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4D6KTQ#issuecomment-520611150, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2BCDBLIDTLIR5XBOFN2Y3QEHMJ7ANCNFSM4HWOOSDQ .
When using long-ish source files, a URL is produced that won't render on plantuml.com's web engine. For example:
https://www.plantuml.com/plantuml/img/SoWkIImgAStDuKtKjKjIi5B8ICt9oHyOZhf7Qb6gUh52ea9oVcvkQbx9o1SP-I8ZNsJaYunG4OVKl1HWoGm0
Although I'm not able to say precisely why this happens, after spending some time, here are the details I uncovered:
ZLibWriteStream
isFLEVEL=1
, which is not the default (FLEVEL=2
) and appears to be hard-coded to that level. The headers are set with the method:Digging into the Pharo sources of the VM with some colleagues at RMoD showed that the code is a VM plug-in that was written in 1999. Perhaps FLEVEL=1 was chosen because a modern ZLib wasn't available and it was simpler to code only the "fast" implementation.
localhost
allows these URLs to render, suggesting it's a bug in the www.plantuml.com's server. Perhaps the FLEVEL=1 encoding is tripping up the particular decoder there?/uml/
option of the URL on the server to get the source code back in a<textfield>
of the contents page. Here's a snippet fromStringTest
extensiontestPlantUMLLocalhostRandom
: