fuhrysteve / marshmallow-jsonschema

JSON Schema Draft v7 (http://json-schema.org/) formatting with marshmallow
MIT License
209 stars 72 forks source link

props_ordered does not work for nested fields #129

Open sdefauw opened 3 years ago

sdefauw commented 3 years ago

Fix for the issue described #109

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 711981a4fa1fcc014f093211ae3258e8a8ccd116 on sdefauw:master into becfa24ff798f6efbb019cd9cdeafd51f79aeb76 on fuhrysteve:master.

fuhrysteve commented 3 years ago

Looks like the only thing holding this one back is black formatting: https://travis-ci.org/github/fuhrysteve/marshmallow-jsonschema/jobs/749987034

sdefauw commented 2 years ago

I should be okay now

sdefauw commented 2 years ago

@fuhrysteve Can you look if all is okay for you now ?

Quasarman commented 2 years ago

Facing the same issue, can we merge this change by any chance? Would be great since this is a awesome package.

sdefauw commented 1 year ago

@fuhrysteve What is missing in order to validate the pull request?

sdefauw commented 7 months ago

@fuhrysteve Can we have some new about this merge request ?