search

fuhrysteve / marshmallow-jsonschema

JSON Schema Draft v7 (http://json-schema.org/) formatting with marshmallow
MIT License
209 stars 72 forks source link

Handle validate.oneOf(iterable) #54

Closed erik closed 6 years ago

erik commented 6 years ago

According to the marshmallow docs for validate.OneOf, the enum choices and labels are iterables, not necessarily lists.

Fixes a bug where a valid Marshmallow schema run through marshmallow-jsonschema could generate an object that could not be serialized as JSON.

See behavior without the patch for details

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0907857083fc8f10a5c1484925df2cdc567a4b5b on erik:handle-iterable-oneof into f6c2daecdab2580fb37eb7bf02b3eefd8176de1d on fuhrysteve:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f383805e282e752425884233abdd9d1713ac623f on erik:handle-iterable-oneof into 17137e3369f902c1a86ae485290892778dff7c37 on fuhrysteve:master.

erik commented 6 years ago

@fuhrysteve polite bump since it's been a few months

fuhrysteve commented 6 years ago

Thanks!!