search

fujiapple852 / trippy

A network diagnostic tool
https://trippy.cli.rs
Apache License 2.0
3.5k stars 73 forks source link

Tracer panic for ICMP extension #1287

Closed fujiapple852 closed 3 weeks ago

fujiapple852 commented 4 weeks ago

Tracer panic:

thread 'tracer-23144' panicked at crates/trippy-packet/src/icmp_extension.rs:426:33:
range end index 42973 out of range for slice of length 416

Attempting to reproduce and capture the offending packet.

fujiapple852 commented 4 weeks ago

Unable to reproduce whilst capturing packets. Instead I created a synthetic test case based on the error message and fixed based on that. Provisional fix in #1294.

fujiapple852 commented 3 weeks ago

Still unable to reproduce despite exhaustive attempts.

The change in https://github.com/fujiapple852/trippy/pull/1294 fixes an issue and even if it does not fix the issue (it almost certainly does) it is still a valid fix and will be merged.