search

fujiisoup / py3nj

Wigner's 3J, 6J, 9J symbols for python
https://py3nj.readthedocs.io/
Apache License 2.0
18 stars 5 forks source link

Build wheels with `cibuildwheel` #31

Closed kalekundert closed 1 year ago

kalekundert commented 1 year ago

I just mentioned this branch in #30, but it occurred to me that it would probably be more convenient to open a PR.

fujiisoup commented 1 year ago

Thank you @kalekundert for your help. Merging.

We already know that the source installation works, so providing a wheel is a convenience rather than a necessity.

I agree, and I think it is OK for now without Windows' wheel. But this is unfortunate that we can't make it for Windows, which may have the installation problem the most often.

I will add some notes about the installation.

kalekundert commented 1 year ago

But this is unfortunate that we can't make it for Windows, which may have the installation problem the most often.

Yeah, I agree. I thought that since we already had the windows build working on CI, making a wheel at the same time would be no problem. But I guess nothing is easy. :smile: