fujitatomoya
commented
2 months ago github workflow design
- always check with corresponding latest mainline with source build https://github.com/ros2/ros2.
- fetch the PR's target branch, and set up the colcon workspace and source code from mainline accordingly.
- build and test the package, see https://github.com/fujitatomoya/rcl_logging_syslog/issues/14#issuecomment-2372553340
- backports also need to have workflow based on the target branch.
i think we can have Dockerfile and test script with argument with target branch or distro name. create the target distro environment with them, and start the test in the container to make sure all tests are working okay with rsyslog. since this test is going to be running in the container or virtualized environment, we would not have system services. that means we can install rsyslog deb package and manually start the daemon in the background with test configuration.
depends on https://github.com/fujitatomoya/rcl_logging_syslog/issues/9
each distribution has a workflow file to execute the unit tests provided by https://github.com/fujitatomoya/rcl_logging_syslog/issues/9 to make sure each PR does not break the package.