search

fujitatomoya / rcl_logging_syslog

rcl_logging_syslog is alternative logging backend implementation that can be used for ROS 2 application via rcl_logging_interface.
https://github.com/fujitatomoya/rcl_logging_syslog
Apache License 2.0
65 stars 0 forks source link

spam message during `colcon test` #23

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 2 months ago

we can see Failed to remove /var/log/rcl_logging_syslog directory message comes from the test fixture, those are kinda annoying. I think we need to check if the directory exits, and the proceed to remove it. same patch could be applied to https://github.com/ros2/rcl_logging

1: [ RUN      ] LoggingTest.log_file_name_prefix
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.log_file_name_prefix (1000 ms)
1: [ RUN      ] LoggingTest.use_different_facilities
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.use_different_facilities (3003 ms)
1: [ RUN      ] LoggingTest.full_cycle
1: Failed to remove /var/log/rcl_logging_syslog directory
1: [       OK ] LoggingTest.full_cycle (1001 ms)
1: [----------] 3 tests from LoggingTest (5004 ms total)
fujitatomoya commented 2 months ago

This is on hold, i will set up the github workflow to make sure the PR does not break the test to take the PRs.