search

fujitsu-pio / io

This repository is not updating now but hosted for archiving older versions than 1.4.1. Latest version is in "personium-core" .
https://github.com/personium
Apache License 2.0
29 stars 13 forks source link

client-js: Avoid polluting global namespace by 'exports' #1

Closed oimou closed 9 years ago

oimou commented 9 years ago

When you use RequireJS, if 'exports' object is exposed to the global namespace, some AMD modules which change their behavior by checking whether 'exports' exists in the global namespace, are wrongly treated as CommonJS module.

oimou commented 9 years ago

It is incomplete as module definition, so I would like to close this PR.

poporin commented 9 years ago

Hi oimou

Thank you for PR and sorry for slow response.

This library is for browser and "import" is not done , so I will remove occurrences of exports of ClientException and RestAdapterand DcContext.（This means removing 'exports' globaly pollution.）

And these occurrences of exports are confusing.

regards popolin