search

fujitsu / xbyak_aarch64

Apache License 2.0
186 stars 39 forks source link

Add test for "mov" and "(mov|add|adds|sub|subs)_imm" #67

Closed bkmgit closed 1 year ago

bkmgit commented 1 year ago

Additional tests for arithmetic and mov to be used in CI. Addressing https://github.com/fujitsu/xbyak_aarch64/issues/27 Unclear if the codes should be refactored.

kawakami-k commented 1 year ago

Thank you for the PR, but the tesfs of *_imm have already been implemented as mov_imm.cpp and add_sub_adds_subs_imm.cpp.

These files should be compiled and executed in test_all.sh.

bkmgit commented 1 year ago

test_all.sh calls test_integrated.sh which compiles and executes mov.cpp, mov_imm.cpp and add_sub_adds_subs_imm.cpp. Should the contents of test_integrated.sh be put in test_nm.sh which is what calls the other tests? A few changes are needed to run these tests compared to the other tests in test_nm.sh.

kawakami-k commented 1 year ago

test_all.sh calls test_integrated.sh which compiles and executes mov.cpp, mov_imm.cpp and add_sub_adds_subs_imm.cpp. Should the contents of test_integrated.sh be put in test_nm.sh which is what calls the other tests? A few changes are needed to run these tests compared to the other tests in test_nm.sh.

Sorry, I made a mistake. You're right. Thank you for the contribution.

bkmgit commented 1 year ago

Welcome. Thanks for the code.