search

fukamachi / caveman

Lightweight web application framework for Common Lisp.
http://8arrow.org/caveman/
775 stars 63 forks source link

Have .asd files follow recommended ASDF practice #95

Closed fare closed 5 years ago

fare commented 7 years ago

Most importantly, stop calling clear-system from perform. BAD BAD BAD.

Use "strings" as canonical system names.

Do not define long description by default, but for those who want to read it from a file (not recommended), do it a simpler way.

fare commented 7 years ago

PING

ramonkeypr commented 7 years ago

@fare, does your branch need to update update the Travis CI script, or are there changes that need to occur in your code to make the tests pass?

https://travis-ci.org/fukamachi/caveman/jobs/215426458

fare commented 7 years ago

I recently sent fixes to prove that were merged. Can you restart this test with the latest prove?

fare commented 7 years ago

As for me, when I manually run (asdf:test-system :caveman2-test) or (asdf:test-system :caveman-test) from my local patched setup with quicklisp loaded, I get no error — which I believe should be what the tests should do, though I don't understand the ins and outs enough to swear I didn't break the test system somehow (e.g. it says Summary: All 0 files passed.).

fare commented 7 years ago

See explanations in https://gitlab.common-lisp.net/asdf/asdf/blob/master/doc/best_practices.md

fare commented 7 years ago

NB: destroyed https://github.com/fare/caveman and instead created https://github.com/fare-patches/caveman

fare commented 5 years ago

This PR is superseded by #110. Closing.