search

fukamachi / clack

Web server abstraction layer for Common Lisp
MIT License
1.04k stars 86 forks source link

hunchentoot: lift up handler-case in acceptor-dispatch-request #152

Closed dkochmanski closed 6 years ago

dkochmanski commented 6 years ago

Method binds hunchentoot:catch-errors-p to NIL, so hunchentoot tries to invoke a debugger if a condition comes to it. Error condition wasn't handled by clack if it happened in handle-response, because handler-case was wrapped around funcall, not the whole expression.

HANDLE-RESPONSE might have raisen an exception from SSL library (and other communication methods) for instance when peer has closed the connection - that lead to uncought closed stream error condition. Fixes #127.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.08%) to 89.431% when pulling de4cf24b0b4867d50a2044786bb5e12f25dbf42b on dkochmanski:master into ac7f785749a851a81aaee4ec368eae1bc9e7531d on fukamachi:master.

fukamachi commented 6 years ago

Thanks!