fukamachi / clack

Web server abstraction layer for Common Lisp
MIT License
1.04k stars 86 forks source link

Qualify Hunchentoot symbols and remove :use #184

Closed Zulu-Inuoe closed 1 year ago

Zulu-Inuoe commented 1 year ago

This makes the code more consistent in style and makes clear things like what function a method is specializing. Further, handle-request is now clearly the local function rather than the one from hunchentoot by the same name

Zulu-Inuoe commented 1 year ago

Hey all, just a couple of changes while I was learning a bit more about clack and hunchentoot - The code seemed inconsistent about its :use because some symbols still had hunchentoot: and others did not.

I think in reading code (even as the maintainer) it is generally preferable to use prefixes/import-from.

If you'd like to see the code updated to not use prefixes, but to use :import-from on all the symbols, that's something I don't mind doing.

Thanks!

fukamachi commented 1 year ago

Thanks!