fukamachi / clack

Web server abstraction layer for Common Lisp
MIT License
1.04k stars 86 forks source link

Seems, Hunchentoot handler was broken in latest version of Clack #186

Closed svetlyak40wt closed 1 year ago

svetlyak40wt commented 1 year ago

I'm experiencing problems after upgrate to , Ultralisp was broken.

When a test Clack server is started using Hunchentoot:

(defvar *handler* nil)

(defun run-test-app ()
  (setf *handler*
        (clack:clackup
         (lambda (env)
           (declare (ignore env))
           '(200 (:content-type "text/plain") ("Hello, Clack!")))
         :server :hunchentoot
         :address "0.0.0.0"
         :port 80)))

I'm getting this 404 Not Found The requested URL / was not found on this server. error in the browser.

But if I change :hunchentoot with :woo. It works!

Tested on Clack installed from Ultralisp version 20230323053129.

K1D77A commented 1 year ago

Yep just noticed this while deploying a new version of a commercial project :facepalm:

svetlyak40wt commented 1 year ago

Probably we need some sort of smoking test here? Just to ensure that server can be started using all kinds of implementation.

чт, 30 мар. 2023 г., 08:25 Josh Betts @.***>:

Yep just noticed this while deploying a new version of a commercial project 🤦

— Reply to this email directly, view it on GitHub https://github.com/fukamachi/clack/issues/186#issuecomment-1489720048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGB6YS6E6O5D4ZNIO4D4LW6UKKXANCNFSM6AAAAAAWIFQCKA . You are receiving this because you authored the thread.Message ID: @.***>

K1D77A commented 1 year ago

Maybe was this merge? https://github.com/fukamachi/clack/commit/739598fc8339fd56d930fd515e192fe7756753b7

K1D77A commented 1 year ago

Hopefully fixed by https://github.com/fukamachi/clack/commit/488cfb36381a4f4c56ad7f1184ea64b6ebcc2cee

fukamachi commented 1 year ago

Closing this because it's already fixed, I suppose. Feel free to reopen this if you still have the problem.