fukamachi / websocket-driver

WebSocket server/client implementation for Common Lisp
BSD 2-Clause "Simplified" License
104 stars 28 forks source link

:close callback has different arguments than documented #20

Closed vozhyk- closed 7 years ago

vozhyk- commented 7 years ago

The documentation specifies that the callback takes 2 arguments: code reason. However, the code emits the event with :code code :reason reason. The documentation should be updated.

knobo commented 7 years ago

Are you able to able to make the :close callback function run when the client closes the connection?

svetlyak40wt commented 7 years ago

This issue was fixed in commit https://github.com/fukamachi/websocket-driver/commit/9fff117f6772d52f4b384481cb036309df5d926d

vozhyk- commented 7 years ago

Thanks, closing.