fukamachi / woo

A fast non-blocking HTTP server on top of libev
http://ultra.wikia.com/wiki/Woo_(kaiju)
MIT License
1.28k stars 98 forks source link

Limiting maximum size for receiving large post data #62

Closed resttime closed 7 years ago

resttime commented 7 years ago

When we POST data like a large file upload, woo downloads it all to a temporary file via smart-buffers. If we could possibly limit the maximum size, it would be useful for enforcing a hard file upload limit. Would this be a desirable feature or should it be handled independently via client-side/proxy-server?

I know PHP likes to download a file before checking the filesize. However nginx has something like this: https://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size, so I'm wondering what stance woo has.

resttime commented 7 years ago

I suppose this is a non issue, I don't really imagine many people using webservers without a reverse proxy.