cbmp -wc option replaces wrong color

[tedric42]

I was trying to create a custom cursor with pink background, black outline, and white watch animation. I ran the following command:

npx cbmp -d "svg" -o "bitmaps/Notwaita-Pink" -bc '#ff00cc' -oc '#000000' -wc '#ffffff'

The result was that the png files for the watch animations all had their background colors relpaced with white. The spinner itself remained default yellow.

I was able to work around this by editing the render.json file and copying the examples. There are 4 color replacement rules for each theme in that file, so I think the cbmp command either needs to take 4 arguments or the -wc argument needs to target a different color for replacement.

[ful1e5]

There are 4 color replacement rules for each theme in that file, so I think the cbmp command either needs to take 4 arguments or the -wc argument needs to target a different color for replacement. Certainly!

You’re right. This cursor theme has 4 color keys for replacement. The watch color key is hardcoded with #FF0000. Changing this hardcoded color to align with the theme might cause issues for other cursor themes. This is because configuration file support was added in cbmp v1.0.0, and some of my cursors still use the older method of rendering via command line.

I plan to deprecate the command-line option in favor of the configuration file approach in future updates of cbmp.

For now, if you want to customize colors, please use the configuration file. Inshallah, I will add support for variable color replacement in the next release of cbmp, using command line options.

[tedric42]

OK, thanks for letting me know! I appreciate your work on this.

~Ted

---

Ted Burnham [he, him, his]

@.*** (203) 247-9330 tedburnham.com Schedule time with me: Click here https://calendly.com/tedburnham/

TERMS OF USE. By reading this e-mail, you agree, on behalf of your employer, to release me from all obligations and waivers arising from any and all NON-NEGOTIATED agreements, terms-of-use, licenses, terms-of-service, shrinkwrap, clickwrap, browsewrap, confidentiality, non-disclosure, non-compete and acceptable use policies ("BOGUS AGREEMENTS") that I have entered into with your employer, its partners, licensors, agents and assigns, in perpetuity, without prejudice to my ongoing rights and privileges. You further represent that you have the authority to release me from any BOGUS AGREEMENTS on behalf of your employer.

On Wed, Jun 26, 2024 at 1:58 AM Abdulkaiz Khatri @.***> wrote:

There are 4 color replacement rules for each theme in that file, so I think the cbmp command either needs to take 4 arguments or the -wc argument needs to target a different color for replacement. Certainly! Here's a refined response based on your input:

You’re right. This cursor theme has 4 color keys for replacement. The watch color key is hardcoded with #FF0000 https://github.com/ful1e5/cbmp/blob/10b6e72397850fef5f9c5956ef02a3a34d3cdf2d/src/cbmp.ts#L130C4-L137C7. Changing this hardcoded color to align with the theme might cause issues for other cursor themes. This is because configuration file support was added in cbmp v1.0.0 https://github.com/ful1e5/cbmp/releases/tag/v1.0.0, and some of my cursors still use the older method of rendering via command line.

I plan to deprecate the command-line option in favor of the configuration file approach in future updates of cbmp.

For now, if you want to customize colors, please use the configuration file. Inshallah, I will add support for variable color replacement in the next release of cbmp, using command line options.

— Reply to this email directly, view it on GitHub https://github.com/ful1e5/notwaita-cursor/issues/2#issuecomment-2190771119, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALI2D7N6KG72AXTYUODE62TZJJJ75AVCNFSM6AAAAABJ4MAT42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQG43TCMJRHE . You are receiving this because you authored the thread.Message ID: @.***>