fulcro-legacy / fulcro-lein-template

A bare-bones lein template
Eclipse Public License 1.0
11 stars 11 forks source link

Template uses old DOM attribute syntax #5

Closed currentoor closed 6 years ago

currentoor commented 6 years ago

For example in {{name}}.ui.components we have

(dom/svg #js {:width w :height h}
  (dom/rect #js {:width w :height h :style #js {:fill        "rgb(200,200,200)"
                                                :strokeWidth 2
                                                :stroke      "black"}})
  (dom/text #js {:textAnchor "middle" :x (/ w 2) :y (/ h 2)} label))

We should probably move this over to the new cleaner DOM syntax (from fulcro v2.5.0).

(dom/svg {:width w :height h}
  (dom/rect {:width w :height h :style {:fill        "rgb(200,200,200)"
                                        :strokeWidth 2
                                        :stroke      "black"}})
  (dom/text {:textAnchor "middle" :x (/ w 2) :y (/ h 2)} label))

I'm happy to work on this if you'd like.

awkay commented 6 years ago

Again, feel free to fix.