fulcrologic / fulcro-rad

Fulcro Rapid Application Development
MIT License
201 stars 46 forks source link

Form: Don't duplicate id in the query if also in fo/attributes #123

Closed holyjak closed 8 months ago

holyjak commented 8 months ago

Issue: If you add the form's id attribute also to its fo/attributes then it will end up being twice in the query, because the fo/id is always added there. This is not a problem per se, but it makes fulcro-troubleshooting warn unnecessarily about this duplicate (duplicates may lead to surprising results, if they diff, i.e. once a raw :xx, once a join {:xx ..}.

Fix: Remove the id from attributes before creating the query.

holyjak commented 8 months ago

Tested in fulcro-rad-demo, on the address from with address/id added to attributes.

awkay commented 8 months ago

Thanks!