search

fulcrologic / fulcro

A library for development of single-page full-stack web applications in clj/cljs
http://fulcro.fulcrologic.com
MIT License
1.55k stars 140 forks source link

:fulcro.client.primitives/component-or-reconciler spec looks wrong #189

Closed OscarMarshall closed 6 years ago

OscarMarshall commented 6 years ago

The spec here looks wrong.

Instead of:

(s/def ::component-or-reconciler vector?)

I believe it should be:

(s/def ::component-or-reconciler (s/or :component component?, :reconciler reconciler?))

Or I have grossly misunderstood what this spec is intended to be used for. It looks like it's not actually used anywhere, though, so I'm guessing it just slipped through the cracks.

awkay commented 6 years ago

I would agree that it is wrong...not sure how that ended up in there...probably copy-pasted something, got interrupted, and forgot where I was.