fulcrologic / fulcro

A library for development of single-page full-stack web applications in clj/cljs
http://fulcro.fulcrologic.com
MIT License
1.55k stars 140 forks source link

[SSR] incorrect escapes around CSS inline scripts #299

Closed nha closed 5 years ago

nha commented 5 years ago

Server-side rendering example: clj code: (def garden-css {:font-family "\"Helvetica Neue\""})

ends up being rendered on the sever as: font-family: "Helvetica Neue" which is invalid.

The above clj works fine on the client, however the client escapes the single-quote version:

awkay commented 5 years ago

Fixed in Beta 5.

Will accept a PR against the fulcro 2 branch to back port if anyone cares to do it.