fulcrologic / fulcro

A library for development of single-page full-stack web applications in clj/cljs
http://fulcro.fulcrologic.com
MIT License
1.54k stars 137 forks source link

dr/change-route-relative! -- denied route does not call :route-denied component option #540

Closed jmurp closed 1 year ago

jmurp commented 1 year ago

change-route-relative! does not trigger the :route-denied function defined on the target component

The call in this function after (not (can-change-route? app-or-comp relative-class)) evaluates to true: (target-denying-route-changes app) returns a null target even though a target did deny the route. I think this line should be: (target-denying-route-changes app relative-class) because this seems to works in my case. I have multiple on screen routers.

awkay commented 1 year ago

Fixed in 3.6.4