search

fulcrologic / guardrails

Efficient, hassle-free function call validation with a concise inline syntax for clojure.spec and Malli
Eclipse Public License 2.0
237 stars 25 forks source link

Remove core async #42

Closed RokLenarcic closed 6 months ago

RokLenarcic commented 6 months ago

From:

(time (require '[com.fulcrologic.guardrails.malli.core]))
"Elapsed time: 7330.943292 msecs"

to

(time (require '[com.fulcrologic.guardrails.malli.core]))
"Elapsed time: 3880.868583 msecs"
RokLenarcic commented 6 months ago

I am not sure that tests cover async use case, so I'll try to fix more tests.

RokLenarcic commented 6 months ago

Tested it by hand.

gnl commented 6 months ago

You know what, as hinted at in the original issue, we ended up deciding to get rid of the async feature altogether – it's no longer needed with the newest performance improvements (that's why I wanted to hold off on this PR initially, hope you didn't put too much time into it). Would you mind updating the PR to just cleanly remove everything related to the async checks?

RokLenarcic commented 6 months ago

No problem, but I'll do it tomorrow. It's late here.

RokLenarcic commented 6 months ago

Didn't take long, so I did it now.