search

fulcrumapp / fulcrum-expressions

Fulcrum expressions engine
http://developer.fulcrumapp.com/expressions/intro/
5 stars 0 forks source link

Internal storage for callback hooks should be an object #19

Closed zhm closed 8 years ago

zhm commented 8 years ago

The backing storage for the event listeners should be an object instead of an array. We should also prefix the keys with something so they don't accidentally collide with something else. Currently you cannot have a field with a data name that's the same as anything on Array.prototype

https://github.com/fulcrumapp/fulcrum-android/issues/427 https://github.com/fulcrumapp/fulcrum-ios/issues/373 https://github.com/fulcrumapp/fulcrum/issues/2357

zhm commented 8 years ago

The broken code is in here https://github.com/fulcrumapp/fulcrum-expressions/blob/master/runtime.coffee#L188-L200

zhm commented 8 years ago

This should be resolved in 84a13c33fff0d91412a775786e9e87d6394edb19

zhm commented 8 years ago

This will be deployed in the next versions of the mobile apps.