search

fulcrumapp / fulcrum-expressions

Fulcrum expressions engine
http://developer.fulcrumapp.com/expressions/intro/
5 stars 0 forks source link

Implement DATEADD fix for daylight savings #37

Closed Jirles closed 8 months ago

Jirles commented 5 years ago

Changes the way DATEADD function calculates dates to make it more daylight savings friendly. Based off of how date-fns implements its addDays method: https://github.com/date-fns/date-fns/blob/master/src/addDays/index.js#L33-L35

Also removes unnecessarytype parameter. Not only did type force a no-op if any value besides the default "days" was added, it wasn't even mentioned in our online documentation.

tylerjohnst commented 5 years ago

Looks good to me 👍