Closed mjhipp closed 1 year ago
@nh13 I added one more line to the error message
Failed checks are from 2 test suites being aborted based on env. One is log4j, other is Intel deflater related
@mjhipp can you rebase onto main now that #918 is merged?
Patch coverage: 40.00
% and project coverage change: -0.04
:warning:
Comparison is base (
84a99c6
) 95.65% compared to head (4c72da0
) 95.61%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @mjhipp !
This is a proposed addition of an optional minimum kept ratio input to
CorrectUmis
. If used, the value must be between 0 and 1, and will cause an error if the ratio of kept/total reads is below the provided minimum value. The error occurs after writing all output files and metrics.The reasoning for this addition is to catch an instance of a user providing the wrong input UMI list, or a user performing
CorrectUmis
on a library preparation that did not use defined UMIs. In both of those cases,CorrectUmis
would filter the majority of reads, leaving a very small BAM output file, and complete successfully. In the case of a long pipeline, this UMI incompatibility may not be caught until all other analyses are completed, or at all. With this change, setting a minimum kept ratio as low as 0.01 could catch the error in most cases.