fulcrumgenomics / fgbio

Tools for working with genomic and high throughput sequencing data.
http://fulcrumgenomics.github.io/fgbio/
MIT License
309 stars 67 forks source link

fix: ensure that the GroupReadsByUmiTests for marking duplicates are #962

Closed nh13 closed 7 months ago

nh13 commented 7 months ago

actually run

The tests did not check for non-empty output, so would pass even if the tool was not being executed

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (afa634e) 95.62% compared to head (a4cec0c) 95.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #962 +/- ## ======================================= Coverage 95.62% 95.62% ======================================= Files 126 126 Lines 7355 7355 Branches 528 528 ======================================= Hits 7033 7033 Misses 322 322 ``` | [Flag](https://app.codecov.io/gh/fulcrumgenomics/fgbio/pull/962/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fulcrumgenomics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fulcrumgenomics/fgbio/pull/962/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fulcrumgenomics) | `95.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fulcrumgenomics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.