search

fulcrumgenomics / fgpyo

Quality of life improvements for Bioinformatics in Python.
https://fgpyo.readthedocs.io/en/latest/
Other
27 stars 3 forks source link

`inspect._get_parser()` requires the now-deprecated `typing.*` collection types #143

Open msto opened 4 months ago

msto commented 4 months ago

https://peps.python.org/pep-0585/

Importing those from typing is deprecated. Due to PEP 563 and the intention to minimize the runtime impact of typing, this deprecation will not generate DeprecationWarnings. Instead, type checkers may warn about such deprecated usage when the target version of the checked program is signalled to be Python 3.9 or newer. It’s recommended to allow for those warnings to be silenced on a project-wide basis.

The deprecated functionality may eventually be removed from the typing module. Removal will occur no sooner than Python 3.9’s end of life, scheduled for October 2025.

https://github.com/fulcrumgenomics/fgpyo/blob/cd554be7f376ed30504ec2c7fafc041012732b0d/fgpyo/util/inspect.py#L346-L353

TimD1 commented 2 months ago

Is the plan for this issue to remove typing.List (and other types) from inspect._get_parser only, or to also more generally replace all usage of typing.List with list?