Open msto opened 1 month ago
I agree! From the Zen of Python:
Errors should never pass silently.
I would like a way to see all logs from Primer3, perhaps by using the logging module and having the important logs set to INFO
/WARNING
and all the rest DEBUG
.
Sister issue for bwa:
primer3_error()
fails to propagate errors when the logged error includes an equals sign.When this occurs, the line is stored in
primer3_results
rather thanerror_lines
.Could we add stricter validation/parsing of the primer3 output, so underlying error messages are visible?
https://github.com/fulcrumgenomics/prymer/blob/8d332df27d1a467dd66369cc2e16183f033ab8d2/prymer/primer3/primer3.py#L402-L412
https://github.com/fulcrumgenomics/prymer/blob/8d332df27d1a467dd66369cc2e16183f033ab8d2/prymer/primer3/primer3.py#L423-L435