fulcrumgenomics / prymer

Python Primer Design Library
https://prymer.readthedocs.io/en/latest/
MIT License
8 stars 0 forks source link

feat: Primer3 takes a list of VCFs instead of a VariantLookup object #62

Open emmcauley opened 1 week ago

emmcauley commented 1 week ago

Closes #53.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.26%. Comparing base (c434b1d) to head (0a83439).

Files with missing lines Patch % Lines
prymer/primer3/primer3.py 84.61% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #62 +/- ## ========================================== - Coverage 97.37% 97.26% -0.11% ========================================== Files 25 25 Lines 1601 1610 +9 Branches 302 303 +1 ========================================== + Hits 1559 1566 +7 - Misses 23 24 +1 - Partials 19 20 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tfenne commented 1 week ago

I'd appreciate @msto's feedback on this PR. I think original the thought was it would just be a list of VCFs vs. a VariatnLookup, but the reality of it being 4 parameters that control how variants are read from VCFs, makes it less desirable IMHO.

I think I would propose either:

But I'd wait for @msto's input before doing anything further.