Open emmcauley opened 1 week ago
Attention: Patch coverage is 84.61538%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 97.26%. Comparing base (
c434b1d
) to head (0a83439
).
Files with missing lines | Patch % | Lines |
---|---|---|
prymer/primer3/primer3.py | 84.61% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'd appreciate @msto's feedback on this PR. I think original the thought was it would just be a list of VCFs vs. a VariatnLookup, but the reality of it being 4 parameters that control how variants are read from VCFs, makes it less desirable IMHO.
I think I would propose either:
VariantParams
) to hold a list of VCFs and all the other parameters that effect VariantLookup creation, and then optionally take that in primer3.py? (Or VariantParams | VariantLookup | None
).But I'd wait for @msto's input before doing anything further.
Closes #53.