search

fulcrumgenomics / prymer

Python Primer Design Library
https://prymer.readthedocs.io/en/latest/
MIT License
8 stars 0 forks source link

feat: use OffTargetDetector and ExecutableRunner as ContextManagers #64

Closed clintval closed 1 week ago

clintval commented 1 week ago

Since OffTargetDetector and ExecutableRunner are context managers, it makes sense to type them as such by having them inherit from the abstract manager base class. This PR also fixes an issue where if tests fail, IO resources are not cleaned up since context managers were not being used.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.38%. Comparing base (c434b1d) to head (05f716e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #64 +/- ## ======================================= Coverage 97.37% 97.38% ======================================= Files 25 25 Lines 1601 1605 +4 Branches 302 302 ======================================= + Hits 1559 1563 +4 Misses 23 23 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.