fulcrumgenomics / prymer

Python Primer Design Library
https://prymer.readthedocs.io/en/latest/
MIT License
8 stars 0 forks source link

feat: ensure FileBasedVariantLookup is used as a context manager #71

Open clintval opened 3 days ago

clintval commented 3 days ago

The FileBasedVariantLookup opens one or more pysam.VariantFile objects but provides no public API for closing them. The file-based lookup should have a public method for closing the file handles and should also support use as a context manager so there are safe ways to cleanup IO resources.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.78%. Comparing base (93ea6e7) to head (00fa54b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== + Coverage 96.76% 96.78% +0.02% ========================================== Files 26 26 Lines 1701 1713 +12 Branches 328 329 +1 ========================================== + Hits 1646 1658 +12 Misses 29 29 Partials 26 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.