Open keviniano opened 4 months ago
The new way of moving trips and runs from review to archive doesn't handle errors gracefully. It's possible for trips to be moved, but for runs to have an error, leaving things in a state where moving runs must be done "manually" using custom code.
The fix should be that neither trips nor runs are deleted from the review tab until all records are successfully copied over. https://github.com/full-path/ridesheet/blob/0c5a7ccbef49ce67bd72610a924519770ec64fac/review.js#L277C1-L282C21
The new way of moving trips and runs from review to archive doesn't handle errors gracefully. It's possible for trips to be moved, but for runs to have an error, leaving things in a state where moving runs must be done "manually" using custom code.
The fix should be that neither trips nor runs are deleted from the review tab until all records are successfully copied over. https://github.com/full-path/ridesheet/blob/0c5a7ccbef49ce67bd72610a924519770ec64fac/review.js#L277C1-L282C21