search

fullboar / vc-showcase

Themeable Demo of Verifiable Credentials
Apache License 2.0
0 stars 2 forks source link

chore: Extract hardcoded strings into localization dictionary #16

Closed adamgrharvey closed 10 months ago

adamgrharvey commented 10 months ago

Hardcoded Strings extraction

https://github.com/fullboar/vc-showcase/issues/1

Adds a localization.ts file to /web/src/assets. This file is imported in necessary components, where the hardcoded strings have been extracted out, and placed into the localization file. This file can be modified in the future to address needs for additional themes added.

My goal with the organization was simplicity, and consistency. The localization object contains nested objects for each page and their components. i.e. landingPage, onboarding, useCase, dashboard, as well as the /components folder and subfolders.

Each of these strings is named in a basic format relative to the string it contains, or relative to the role the string performs.

Please let me know if these need to be modified, or redone with a specific format.

adamgrharvey commented 10 months ago

@jleach Hey Jason, this is ready for your review