chore: remove `explicit-any` global ignore, review each instance of `any`

fullboar / vc-showcase

Themeable Demo of Verifiable Credentials

Apache License 2.0

0 stars 2 forks source link

chore: remove `explicit-any` global ignore, review each instance of `any` #24

Closed adamgrharvey closed 11 months ago

adamgrharvey commented 11 months ago

@weslord

weslord commented 11 months ago

Given this some thought and would recommend leaving the global rule instead of inline overrides.

Inline overrides imply a deliberate long-term choice to use any.
Much easier to disable the global rule to find all these when improving types in the future.

I would also recommend running yarn test:lint after changing the top-level .eslintrc.js, looks like there are a bunch of explicit-any warnings on the backend now.

jleach commented 11 months ago

@adamgrharvey Sorry, missed @weslord commend and merged this.

adamgrharvey commented 11 months ago

@adamgrharvey Sorry, missed @weslord commend and merged this.

No problem, I will eventually go through and refactor the instances of any and resolve it anyway.